feat: add request-offline-floating-license #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-kemsan
reviewed
Aug 1, 2024
src/lexfloatclient.ts
Outdated
| @@ -58,7 +58,7 @@ export class HostProductVersionFeatureFlag { | |||
| export class LexFloatClient { | |||
| /** | |||
| * Sets the product id of your application. | |||
| * | |||
|
|
|||
There was a problem hiding this comment.
@muneebkq why this change?
ahmad-kemsan
reviewed
Aug 1, 2024
| * The maximum value of lease duration is configured in the config.yml of LexFloatServer | ||
| * | ||
| * @param {number} leaseDuration seconds to lease the license for | ||
| * @throws {LexFloatClientException} |
There was a problem hiding this comment.
@muneebkq Please refer to the header file docs for lease duration.
There was a problem hiding this comment.
value of the lease duration.
ahmad-kemsan
reviewed
Aug 1, 2024
src/native/LexFloatClient.h
Outdated
| The maximum value of lease duration is configured in the config.yml of LexFloatServer | ||
|
|
||
| PARAMETERS: | ||
| * leaseDuration - value of the lease duration. |
There was a problem hiding this comment.
@muneebkq Why is the leaseDuration property added as param for RequestFloatingLicense(). There seems to be other docs mistakes as well. Please check the docs again.
ahmad-kemsan
reviewed
Aug 1, 2024
|
|
||
| PURPOSE: Sends the request to lease the license from the LexFloatServer for offline usage. | ||
|
|
||
| RETURN CODES: LF_OK, LF_FAIL, LF_E_PRODUCT_ID, LF_E_LICENSE_EXISTS, LF_E_HOST_URL, |
There was a problem hiding this comment.
@muneebkq Why is the parameter missing here?
ahmad-kemsan
requested changes
Aug 1, 2024
|
@muneebkq There are some merge conflicts as well. Please address them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add request offline floating license