Fix broken urls in README #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
added
the
documentation-only
Tobychev
previously approved these changes
Oct 16, 2023
|
Rebasing with main will fix the docs build |
LukasNickel
previously approved these changes
Oct 25, 2023
|
Something went wrong in your rebasing |
Yeah, can't figure out what, though... |
|
Did you update upstream before the rebase? ? |
|
Yup, which is why I'm confused |
Set navigation_with_keys to False to get rid of the warning. Setting it to True has negative accessibility implications: pydata/pydata-sphinx-theme#1492
maxnoe
force-pushed
the
fix_broken_urls_in_readme
branch
from
e4f3a9c to
38d38d8
Compare
maxnoe
approved these changes
Oct 26, 2023
kosack
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken urls in the README after the restructuring of the docs.