Added option to make expanded images fit to screen, ran inline-expanding.js through jshint

[ghost]

Adds an option in general options tab to make inline expanded images to fit to your screen like 4chan's 'fit expanded images to screen' option

[czaks]

same problem as with all your scripts. you pollute the global namespace when not needed. incorrect usage of options api. use of names like $mrCheckie instead of some descriptive ones.

[ctrlcctrlv]

@czaks been having same problem with @anonfagola too, I had to rewrite his scripts today (id_colors.js, id_highlight.js) because of this

We should probably push some code quality guidelines into here and vichan-devel/vichan given all the new help we're getting

[anonfagola]

@ctrlcctrlv :(
but yeah i agree 100%

[czaks]

it's hard to write all code quality guidelines to a file. that's why we have code review. people should learn by reading existing code.

with just javascript, it's not that hard and stability is not critical. just note on how hard it is to submit a patch to linux kernel for instance :)

[czaks]

btw. https://github.com/ctrlcctrlv/8chan/pull/20/files this code is really clean, @anonfagola .

a code should be short, concise, just like this one. and in my opinion, we shouldn't fix pull requests ourselves, but tell our committers, what is wrong. this way they would learn.

[ghost]

Uses options API now, $mrCheckie variable removed. Global variables removed hopefully.

[aeosynth]

re code quality, we could use a linter, such as jshint

[czaks]

this.childNodes[0] keeps being repeated in the code.

there are a few indentation problems

if (window.Options && Options.get_tab("general")){ forbids use of the script without Options enabled

+ Options.extend_tab('general', '<div><label id=\"toggle-image-fittoscreen\"><input type=\"checkbox\"> fit expanded images to screen.</label></div>');

make it:

+ Options.extend_tab('general', '<div><label id=\"toggle-image-fittoscreen\"><input type=\"checkbox\"> '+_("Fit expanded images to screen.")+'</label></div>');

in order to make it l10nable

var isSpoiler = (fileInfo.indexOf("Spoiler") > -1) ? true:false;

you can shorten it to:

var isSpoiler = fileInfo.indexOf("Spoiler") > -1;

[ghost]

Thanks czaks I've followed your advice. I've also attempted to fix my indentation issues as well.
Instead of calling 'this.childNodes[0]' I've declared a variable called childNode which is assigned the value of 'this.childNodes[0]' I don't know if this has fixed the repeating issue you've mentioned.