-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(databricks-driver): Enable Azure AD authentication via service principal #6763
base: master
Are you sure you want to change the base?
feat(databricks-driver): Enable Azure AD authentication via service principal #6763
Conversation
Hello @paveltiunov, how are you doing? Thanks for providing this amazing product, our team depends on Cube to build our data analytics app, and we would like to support authentication via the Azure service principal. It will be highly appreciated if colleagues could help to review this PR. Thanks in advance and sorry for any inconvenience. |
Hello @pacofvf, would you be willing to help re-trigger the workflows? The last running failed, but it seems not related to my changes, many thanks and have a nice day! |
This is a cool enhancement feature on security perspective, we'd like to have the same. Looking forward to get this features merged into master branch.😁 |
Hello @pacofvf Sorry for bothering you, would you please help to re-trigger the workflows again? And it would be highly appreciated if my changes could be reviewed. |
@MaggieZhang-01 is attempting to deploy a commit to the Cube Dev Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
@paveltiunov I have fixed the issue you mentioned, please feel free to approach me if there are any concerns. Much appreciated! |
@MaggieZhang-01 Great job on this PR! Could you please kindly update this documentation page (https://github.com/cube-js/cube/blob/master/docs/pages/reference/configuration/environment-variables.mdx) with new environment variables as well? Thank you in advance! |
@igorlukanin Thanks, I have updated the docs, please help to verify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs changes LGTM. Thank you, @MaggieZhang-01!
Hello @paveltiunov , still need your review and approve, would you help on this PR, thanks. |
I voted this feature, when this can be merged? |
@MaggieZhang-01 Could you please resolve the conflicts and sync with the latest changes in |
Gentle ping @MaggieZhang-01 .... |
Okay... I took it into my own hands, rebased, and updated it. #9104 |
Check List
Description of Changes Made (if issue reference is not provided)
In the Databricks driver, the credential is generated by the Azure storage account access key now which provides full access to the storage account. For security best practice, Microsoft recommends using authorization with Azure Active Directory.
This PR is used to support Azure AD authentication via service principal which provides more fine-grained control over access to storage resources.