Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-core): Specify maximum for continueWaitTimeout (90 seconds) #7301

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Oct 25, 2023

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner October 25, 2023 20:10
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:41am

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e722dd) 47.04% compared to head (a7602ff) 47.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7301   +/-   ##
=======================================
  Coverage   47.04%   47.04%           
=======================================
  Files         155      155           
  Lines       20768    20768           
  Branches     5224     5224           
=======================================
  Hits         9770     9770           
  Misses      10678    10678           
  Partials      320      320           
Flag Coverage Δ
cube-backend 47.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ges/cubejs-server-core/src/core/optionsValidate.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the fix/options-continue-wait-timeout-max branch from 357130e to a7602ff Compare October 26, 2023 10:37
@ovr ovr merged commit 148fb96 into master Oct 26, 2023
29 checks passed
@ovr ovr deleted the fix/options-continue-wait-timeout-max branch October 26, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant