Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split view support #7308

Merged
merged 1 commit into from
Oct 26, 2023
Merged

feat: Split view support #7308

merged 1 commit into from
Oct 26, 2023

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Oct 26, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner October 26, 2023 02:56
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am
examples-react-data-table ⬜️ Ignored (Inspect) Oct 26, 2023 2:56am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:56am

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (3dad82a) 47.07% compared to head (6de2a23) 47.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7308      +/-   ##
==========================================
- Coverage   47.07%   47.04%   -0.03%     
==========================================
  Files         155      155              
  Lines       20751    20768      +17     
  Branches     5220     5224       +4     
==========================================
+ Hits         9768     9770       +2     
- Misses      10665    10678      +13     
- Partials      318      320       +2     
Flag Coverage Δ
cube-backend 47.04% <23.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bejs-schema-compiler/src/compiler/CubeValidator.js 98.44% <100.00%> (ø)
...cubejs-schema-compiler/src/compiler/CubeSymbols.js 63.48% <20.68%> (-3.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 1e722dd into master Oct 26, 2023
30 checks passed
@paveltiunov paveltiunov deleted the split-view branch October 26, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant