Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Pass proper in_projection flag in non-trivial wrapper pull up rule #9097

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (5e8fc92) to head (25ca740).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9097   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files         225      225           
  Lines       80296    80296           
=======================================
  Hits        66760    66760           
  Misses      13536    13536           
Flag Coverage Δ
cubesql 83.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the fix-in-projection-expr branch 2 times, most recently from bc9d03d to 36e6881 Compare January 16, 2025 13:09
@mcheshkov mcheshkov marked this pull request as ready for review January 16, 2025 15:33
@mcheshkov mcheshkov requested a review from a team as a code owner January 16, 2025 15:33
@mcheshkov mcheshkov force-pushed the fix-in-projection-expr branch from 36e6881 to 25ca740 Compare January 16, 2025 20:49
@mcheshkov mcheshkov merged commit 8f0758e into master Jan 16, 2025
68 checks passed
@mcheshkov mcheshkov deleted the fix-in-projection-expr branch January 16, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants