Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent memory leaks #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent memory leaks #40

wants to merge 1 commit into from
+5 −5

Conversation

Kyome22
Copy link
Contributor

@Kyome22 Kyome22 commented Jan 9, 2025 •
edited
Loading

Since WKWebViewConfiguration, WKUIDelegate, and WKNavigationDelegate are referenced in WKWebView, it is better that they are weakly referenced in the WebView.
Although no specific problems have been found, I think it will help prevent problems.

@Kyome22 Kyome22 requested a review from b1ackturtle January 9, 2025 07:43
@b1ackturtle
Copy link
Collaborator

Good catch, thank you.
To ensure that property references work as expected, could you please implement the unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1ackturtle b1ackturtle Awaiting requested review from b1ackturtle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyome22 @b1ackturtle