Lint: Only warn about -W when used for LSF

[wxtim]

Closes #6550

-W should only be highlighted by Cylc lint when being used in a way which indicates use of LSF.

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
• Tests are included (or explain why tests are not needed).
• Changelog entry included if this is a change that can affect users
• Very small, self documenting.
• Raised against 8.4.x, bugfix

[wxtim]

Looking at https://www.ibm.com/docs/en/spectrum-lsf/10.1.0?topic=o-w-1, I think that this is an LSF wallclock directive which can't be handled by execution time limit and therefore is a legitimate case for using -W with LSF.

[oliver-sanders]

Can you do multiple things with this opt?

e.g -W 00:02 foo=bar

[wxtim]

In LSF or PBS?

In LSF, not really.

In PBS, not really - only key=value pairs.

I don't think that the two are mistakeable.

[oliver-sanders]

I found some suggestion in the user guide that the time can take a longer format:

Resource_List.walltime = 00:30:00

#PBS -l walltime=1:00:00

qsub -l ncpus=16 -l walltime=4:00:00 mysubrun

Maybe: (\d{2}:)+.

Might be worth quickly running this rule over avaliable cylc-run dirs to make sure there aren't any false positives.

[wxtim]

I found some suggestion in the user guide that the time can take a longer format:

This regex is only supposed to match LSF format wallclock strings, avoiding PBS -W which look superficially similar.

The PBS check one will match any case where -l wallclock is present.

I've added an extra test to demonstrate my point.