Xtz polls #769
Merged
Xtz polls #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Man-Jain
reviewed
Feb 8, 2024
| @@ -85,14 +87,19 @@ export const ProposalDetails: React.FC<{ id: string }> = ({ id }) => { | |||
| } | |||
| }) | |||
|
|
|||
| const dataForBack = { | |||
| isXTZ: poll?.isXTZ, | |||
There was a problem hiding this comment.
Don't think we need this now. Should change it to what it was earlier.
Man-Jain
reviewed
Feb 8, 2024
| @@ -174,17 +187,17 @@ export const VoteDetails: React.FC<{ poll: Poll | undefined; choices: Choice[]; | |||
| justifyContent={isMobileSmall ? "flex-start" : "flex-end"} | |||
| > | |||
| <Typography color="textPrimary" variant="body1"> | |||
| {nFormatter(calculateProposalTotal(choices, tokenData?.decimals), 1)} | |||
| {numbro(calculateProposalTotal(choices, isXTZ ? 0 : tokenData?.decimals)).format(formatConfig)} | |||
Man-Jain
reviewed
Feb 8, 2024
| </Typography> | ||
| <Typography color="textPrimary" variant="body1"> | ||
| {poll?.tokenSymbol} | ||
| </Typography> | ||
| <Typography color="textPrimary" variant="body1"> | ||
| ( | ||
| {getTreasuryPercentage( | ||
| calculateProposalTotal(choices, tokenData?.decimals), | ||
| calculateProposalTotal(choices, isXTZ ? 0 : tokenData?.decimals), |
There was a problem hiding this comment.
fix! - Decimals 6
Man-Jain
reviewed
Feb 8, 2024
| @@ -110,7 +119,11 @@ export const VoteDetails: React.FC<{ poll: Poll | undefined; choices: Choice[]; | |||
| {choice && choice.walletAddresses ? ( | |||
| <Typography color="textPrimary" variant="body2"> | |||
| {choice.walletAddresses.length} Voters -{" "} | |||
| {nFormatter(calculateChoiceTotal(choice.walletAddresses, tokenData?.decimals), 1)}{" "} | |||
| {!isMobile | |||
| ? nFormatter(calculateChoiceTotal(choice.walletAddresses, isXTZ ? 0 : tokenData?.decimals), 1) | |||
There was a problem hiding this comment.
XTZ decimals is 18 by default. Unless it's a different case with the data we're getting in this case from the API or Homebase Backend. Do check this once please.
There was a problem hiding this comment.
fix! - Decimals 6
Man-Jain
reviewed
Feb 8, 2024
| {nFormatter(calculateChoiceTotal(choice.walletAddresses, tokenData?.decimals), 1)}{" "} | ||
| {!isMobile | ||
| ? nFormatter(calculateChoiceTotal(choice.walletAddresses, isXTZ ? 0 : tokenData?.decimals), 1) | ||
| : numbro(calculateChoiceTotal(choice.walletAddresses, isXTZ ? 0 : tokenData?.decimals)).format( |
There was a problem hiding this comment.
fix! - Decimals 6
Man-Jain
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763 #764