Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e tests for css modules #693

Merged
merged 7 commits into from
May 4, 2024
Merged

test: add e2e tests for css modules #693

merged 7 commits into from
May 4, 2024

Conversation

negreirosleo
Copy link
Contributor

This PR relates to #186. It adds e2e tests for CSS modules.
I used expect .toContain('class-name') because I was not sure if the generated name would always be the same.

@vercel Vercel
Copy link

vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview May 4, 2024 5:33am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 3, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Owner

dai-shi commented May 3, 2024

@himself65 Hi, would you be able to give a quick review please?

@himself65
Copy link
Contributor

@himself65 Hi, would you be able to give a quick review please?

btw, I was trying to add chromatic for visual test last year, forget to continue on this

@negreirosleo negreirosleo force-pushed the css-modules-e2e branch 2 times, most recently from 933f8e9 to e851c66 Compare May 3, 2024 11:17
@negreirosleo negreirosleo requested review from himself65 and dai-shi May 3, 2024 11:17
@dai-shi
Copy link
Owner

dai-shi commented May 3, 2024

Can you check CI errors? Are they understandable?

@negreirosleo
Copy link
Contributor Author

Can you check CI errors? Are they understandable?

I'm checking it, but I'm having a different error on my machine:
image

am I missing anything? I followed all the CONTRIBUTING.MD steps

@dai-shi
Copy link
Owner

dai-shi commented May 3, 2024

Ah, you need to add a reference in tsconfig.e2e.json.
If it works, feel free to improve CONTRIBUTING.md, thanks!

@negreirosleo negreirosleo requested a review from dai-shi May 3, 2024 14:01
@negreirosleo
Copy link
Contributor Author

I'm checking the final error so we can get this done

himself65
himself65 approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we need to abstract e2e setup script so we don't need to copy paste everything

@negreirosleo
Copy link
Contributor Author

LGTM, maybe we need to abstract e2e setup script so we don't need to copy paste everything

I can work on that if you want

@dai-shi dai-shi merged commit c41ef0c into dai-shi:main May 4, 2024
28 checks passed
@negreirosleo negreirosleo deleted the css-modules-e2e branch May 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@dai-shi dai-shi Awaiting requested review from dai-shi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@negreirosleo @dai-shi @himself65