new defineRouter #949
new defineRouter #949
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| export function NewServerRouter({ route }: { route: RouteProps }) { | ||
| const routeElement = createElement(Slot, { id: getRouteSlotId(route.path) }); | ||
| return createElement( | ||
| Fragment, |
There was a problem hiding this comment.
What is the purpose of this Fragment?
There was a problem hiding this comment.
Maybe, it's to match the component tree with NewRouter. If removing it works, we can remove it. TBH, I don't like NewServerRouter hack. I wish just NewRouter worked.
| return fetchRsc(encodeRoutePath('/404')); | ||
| } | ||
| const data = createData(responsePromise); | ||
| Promise.resolve(data) |
There was a problem hiding this comment.
Does this resolve the responsePromise twice? First on L772 then again here? Or is my understanding off with that?
then if it does resolve twice, shouldn't createData just use response?
There was a problem hiding this comment.
createData requires a promise, so L772 isn't related with L780.
However, yes, data.then((date) => here might work. The reason I added Promise.resolve() is because data returned by createData isn't a real promise. TS types aren't correct here. So, it's just a safe bet. Maybe it's not necessary.
| @@ -0,0 +1,156 @@ | |||
| import { new_defineRouter } from 'waku/router/server'; | |||
| import { Slot, Children } from 'waku/client'; | |||
There was a problem hiding this comment.
is waku/client the best place for these? client to me would mean these are targeted towards the scope of client components, but they're just used here for the router to be able to target where to replace with each level of rendering components (regardless of client vs server)
that is if I understand correctly
There was a problem hiding this comment.
They are client components. We can embed client components in a server component. It's confusing, but it's how it works. createPages API will hide this complexity anyway.
We would like to redesign
defineRouter. This is why we haveunstable_prefix.#885 (comment)
That's the exactly one of the reasons. It shouldn't be 1:1. It can be anything, and it can cache each. This will change waku/router/client too including "shouldSkipList".
Starting with a rough idea.