feat: add Bluesky to Profile Social Links #4052
Open
+65
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elizabetdev is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
|
|
elizabetdev
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
ilasw
reviewed
Jan 8, 2025
| viewBox="0 0 24 24" | ||
| > | ||
| <path | ||
| fill="currentColor" |
There was a problem hiding this comment.
Since we have currentColor here we could just use this svg both for mono/color version. What do you think?
There was a problem hiding this comment.
We don't have any coloured SVGs, so we can just use the same for primary and secondary
There was a problem hiding this comment.
Thanks, @ilasw and @omBratteng. Pushed 0628639.
sshanzel
approved these changes
Jan 9, 2025
ilasw
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds Bluesky to the Profile Social Links.
This feature was requested here:
Fix error with Website and Mastodon fields
Additionally, there was an issue where entering a URL without
httpscaused errors in the Website and Mastodon fields. This happened because theAccountTextFieldwas set as<AccountTextField type="url" />. I’ve removed thetype="url"attribute, aligning it with other fields like Twitter and YouTube, which also don’t specify a type.Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR