Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wrong withdrawal credentials #190

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Handle wrong withdrawal credentials #190

merged 1 commit into from
Oct 31, 2023

Conversation

alrevuelta
Copy link
Collaborator

Bug:

  • A validator with wrong withdrawal credentials (not BLS or ETH1) type can cause the oracle to crash.
  • Fixed by handling this case without panic, warning that its wrong and leaving it empty, since there is nothing we can do.
  • Most likely this wont happen in mainnet but in prater there were 2 validators not respecting this. Example

@alrevuelta alrevuelta merged commit fa2426b into main Oct 31, 2023
4 checks passed
@alrevuelta alrevuelta deleted the fix-credentials branch October 31, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant