-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove default jupyter state vars that triggers requests to unconfigured server on 0.17.x (#338) #341
Conversation
Thank you @MarcosVn. JupyterLab considers you need a server, so the bootstrap part has always been tricky. Could you double check in various scenario (server, nbmodel without server, bringing the servicemanager or the kernel, notebook, cell, terminal, jupyterlabapp, jupyter context, jupyterreacttheme) and confirm there is no negative impact before I merge (just use the examples in webpackconfig). Thank you again! |
Hey @echarles, I tested the following components:
All of them worked well without any apparent inconsistencies caused by the fix for this issue. However, some of them showed problems that occur even in the HEAD of version Some cases include:
Since these issues occur even outside of this PR, I believe we can ignore them, right? One more thing I noticed is that in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thx @MarcosVn
Hey, @echarles, would it be possible for you to publish version |
Just published 0.17.2 https://www.npmjs.com/package/@datalayer/jupyter-react/v/0.17.2 Curious, any reason to stick to 0.17.x and not migrate to latest? |
Thank you, @echarles
The reason was mainly due to the fact that we extensively use the cell-related features in our component, and the evolution: "Kernel state for Cell and Output (#282)" or other similar evolution (I really don't remember 100%, sorry) was introduced after we had already tested and developed based on a previous version. In other words, the idea was to better understand what changed in #282 before using the latest version to avoid risks in our app.
That said, I noticed that even our Taking advantage of the context, @echarles: Were there any relevant adjustments or changes made after #282 that I should be concerned about? |
Thx for sharing context.
It is hard to tell without knowledge of your case and usage. This said, the big changes are before and are moving from Redux to Zustand, and add a useJupyter on top of the Jupyter React Context. At some point staying on 0.17 will limit you for the new big features, happy to help resolving any issue you would report with latest main. |
Fixes one scenario reported in #338.