Add fields for password managers [#31]

davidje13 · Aug 26, 2023 · ec4ed21 · ec4ed21
1 parent 9600348
commit ec4ed21
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/frontend/src/components/common/Input.tsx b/src/frontend/src/components/common/Input.tsx
@@ -34,6 +34,7 @@ export default memo(({
   type,
   value,
   selected,
+  autoComplete = 'off',
   checked,
   onChange,
   ...rest
@@ -60,7 +61,7 @@ export default memo(({
       value={value}
       checked={type === 'radio' ? (selected === value) : checked}
       onChange={changeHandler}
-      autoComplete="off"
+      autoComplete={autoComplete}
       {...rest}
     />
   );

diff --git a/src/frontend/src/components/password/PasswordPage.tsx b/src/frontend/src/components/password/PasswordPage.tsx
@@ -66,12 +66,18 @@ export default ({
         title={`Password for ${slug}`}
       />
       <form onSubmit={handleSubmit}>
+        {/* 'username' is included for password managers to distinguish between retros */}
+        <input type="hidden" name="username" value={retroId} autoComplete="username" />
+        {/* 'name' is a friendly name for password managers (but can be changed) */}
+        <input type="hidden" name="name" value={slug} autoComplete="name" />
         <Input
           type="password"
           placeholder="password"
           value={password}
           onChange={setPassword}
           disabled={sending}
+          autoComplete="current-password"
+          required
         />
         { sending ? (<div className="checking">&hellip;</div>) : (
           <button type="submit" title="Go" disabled={password === ''}>