Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto-recovery #395

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

JamiKettunen
Copy link
Contributor

In some setups it makes sense to launch dinit with --auto-recovery and handle boot failures purely via the recovery service always. Likely missing some stuff etc but this implements the feature in a hopefully proper way.

Fixes #387.

@mobin-2008 mobin-2008 added Enhancement/New Feature Improving things or introduce new feature A-Importance: Normal C-dinit Things about the main parts of dinit labels Oct 14, 2024
@davmac314
Copy link
Owner

Thanks - I will try to review soon

src/dinit.cc Outdated Show resolved Hide resolved
src/dinit.cc Outdated Show resolved Hide resolved
src/dinit.cc Outdated Show resolved Hide resolved
@davmac314
Copy link
Owner

One other thing - the man page (doc/manpages/dinit.8.m4) needs to be updated with the new option.

In some setups it makes sense to launch dinit with --auto-recovery and
handle boot failures purely via the recovery service always.
Copy link
Owner

@davmac314 davmac314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@davmac314 davmac314 merged commit f883bcb into davmac314:master Oct 20, 2024
9 checks passed
@davmac314
Copy link
Owner

I invite contributors to add themselves to the CONTRIBUTORS file if they wish. You are welcome to do this by opening another pull request with that change. Thanks again.

@JamiKettunen JamiKettunen deleted the auto-recovery branch October 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Importance: Normal C-dinit Things about the main parts of dinit Enhancement/New Feature Improving things or introduce new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activatable script/top level service on failure of "boot" one
3 participants