Fix vendorProfileID validation (TheThingsNetwork#783)

* Fix vendorProfileID validation * update pull request template
decentlab · May 7, 2024 · 68b1d41 · 68b1d41
1 parent 3aa4c61
commit 68b1d41
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -23,6 +23,7 @@ Closes #0000, References #0000, etc.
 - [ ] Title and description should be descriptive (Not just a serial number for example).
 - [ ] `profileIDs` should not be `vendorID` and should be a unique value for every profile.
 - [ ] All devices should be listed in the vendor's `index.yaml` file.
+- [ ] Firmware versions can not be changed.
 - [ ] At least 1 image per device and should be transparent.
 
 #### Notes for Reviewers

diff --git a/bin/validate.js b/bin/validate.js
@@ -342,7 +342,7 @@ vendors.vendors.forEach((v) => {
 
           if (!vendorProfiles[vendorID][regionProfile.id]) {
             const profile = yaml.load(fs.readFileSync(`./vendor/${vendorID}/${regionProfile.id}.yaml`));
-            if (profile.vendorProfileID) {
+            if ('vendorProfileID' in profile) {
               console.log(`\n${key}: vendorProfileID exists. This method has been replaced with VendorIDs, see:`);
               console.log(`https://github.com/TheThingsNetwork/lorawan-devices?tab=readme-ov-file#vendor-device-index`);
               process.exit(1);