UpdateHandle - Fix error on call after completion #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a CallAfterHandle's completion disposed another CallAfterHandle or the UpdateHandle itself within the stack the iteration would error/fail. IsDisposed is now checked on each iteration. Improvements to the fix are described in #148
jkeon
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behaviour?
If a CallAfterHandle's completion disposed another CallAfterHandle or the UpdateHandle itself within the stack the iteration would error/fail.
What is the new behaviour?
IsDisposed is now checked on each iteration. Improvements to the fix are described in #148
What issues does this resolve?
What PRs does this depend on?
Does this introduce a breaking change?