Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadPersistentData - Change Name #283

Open
mbaker3 opened this issue Sep 28, 2023 · 0 comments
Open

ThreadPersistentData - Change Name #283

mbaker3 opened this issue Sep 28, 2023 · 0 comments
Labels
effort-low Easy - 1 to 2 hours priority-medium Standard task, plan as you see fit. type-chore Clean-up and optimization

Comments

@mbaker3
Copy link
Member

mbaker3 commented Sep 28, 2023

The naming of ThreadPersistentData is a misleading description of its intended use and behaviour when compared with EntityPersistentData.

ThreadPersistentData is really more of a pooling mechanism for a heavy data type to allow jobs to avoid allocating instances on each iteration of a job, frame and across multiple jobs that use the same type.

The ThreadPersistentDataInstace is:

  • Globally shared between all Worlds
  • Does not get evaluated during World migration

Put some thought into the name but some ideas to riff on are:

  • Instance provider
  • Pooled data
  • Thread safety

ParallelPooledDataProvider?

@mbaker3 mbaker3 added effort-low Easy - 1 to 2 hours priority-medium Standard task, plan as you see fit. type-chore Clean-up and optimization labels Sep 28, 2023
mbaker3 added a commit that referenced this issue Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-low Easy - 1 to 2 hours priority-medium Standard task, plan as you see fit. type-chore Clean-up and optimization
Projects
None yet
Development

No branches or pull requests

1 participant