Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ThreadPersistentData Docs #284

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Update ThreadPersistentData Docs #284

merged 3 commits into from
Sep 28, 2023

Conversation

mbaker3
Copy link
Member

@mbaker3 mbaker3 commented Sep 28, 2023

Minor documentation improvements and calling out the pending work of #283

What is the current behaviour?

What is the new behaviour?

  • Clarified that "World Unique" means unique within the world instance
  • Add //TODO: #283 callouts where appropriate

What issues does this resolve?

  • None

What PRs does this depend on?

  • None

Does this introduce a breaking change?

  • Yes
  • No

@mbaker3 mbaker3 requested a review from jkeon September 28, 2023 14:41
@jkeon jkeon self-assigned this Sep 28, 2023
jkeon
jkeon previously approved these changes Sep 28, 2023
Copy link
Member

@jkeon jkeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion for improvement.

Scripts/Runtime/Entities/Data/IWorldUniqueID.cs Outdated Show resolved Hide resolved
Scripts/Runtime/Entities/Data/IWorldUniqueID.cs Outdated Show resolved Hide resolved
@mbaker3 mbaker3 merged commit 1c6d4e7 into main Sep 28, 2023
@mbaker3 mbaker3 deleted the hotfix-tpd-docs branch September 28, 2023 15:09
@mbaker3 mbaker3 changed the title Hotfix tpd docs Update ThreadPersistentData Docs Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants