refactor: skip variants that doesnt have rule as a function

deco-cx · Dec 8, 2024 · 9059b24 · 9059b24
1 parent 99228f2
commit 9059b24
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/blocks/flag.ts b/blocks/flag.ts
@@ -79,9 +79,10 @@ const flagBlock: Block<BlockModule<FlagFunc>> = {
       let match: Variant<unknown> | null = null;
 
       for (const variant of flag.variants || []) {
-        let ruleResult = typeof variant?.rule === "function"
-          ? variant?.rule(ctx)
-          : null;
+        if (typeof variant?.rule !== "function") {
+          continue;
+        }
+        let ruleResult = variant?.rule(ctx);
         // the rule can sometimes be a promise and we need to await it to check if it's truthy or not
         if (isAwaitable(ruleResult)) {
           try {