[WIP] Make preview SSR only #882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
mcandeia
approved these changes
Jan 2, 2025
|
Don't merge yet. The path from page previews / normal navigation on env is the same of the previews. We should only enable SSR on block preview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block previews are susceptible to high memory usage and may generate excessive requests, especially when dealing with non-cacheable js resources (particularly on localhost calls).
To mitigate these issues, we avoid hydration. Consequently, the server responds with a concise HTML snippet, and the client refrains from using JavaScript to render the section. Nevertheless, we still display apps global sections and elements, ensuring that the theme and any other inserted HTML elements are visible in the preview.
This is a minor step towards resolving the block gallery issue. There are still several aspects that require further attention and improvement.