-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed bug with new panels not always showing initial content #200
base: main
Are you sure you want to change the base?
Conversation
End-to-end Test Summary
Detailed Test Results
Failed Test SummaryNo failed tests ✨Flaky Test SummaryNo flaky tests detected. ✨ |
src/controllers/PanelController.ts
Outdated
// `subscribeToFieldUpdates` handler in DhcService which issues a | ||
// `REFRESH_VARIABLE_PANELS_CMD` command for variables matching existing | ||
// panels. | ||
// 2. Newly created panels that are not the initially active panel (aka. any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is missing the case where the newly created panel is not the initially active panel but it is already visible:
This can happen with the example you provided.
Steps to Reproduce:
- Run the snippet creating
t1
andt2
- Move both panels to a separate tab stack than the code
- Close
t1
- Run the code snippet again
Expected Results
4. t2
should refresh in the location it's in, t1
should open up and load if visible
Actual Results
4. t2
becomes active but t1
shows up as a blank panel. Once selected it becomes visible.
I think there's a follow up here as well, since what I really expect is all the panels to open in the same stack. It's weird/annoying to have the panel open up in the same stack as the code, since now my Editor is blocked. I'd rather it would open all the panels in a new stack on the first run, and on subsequent runs open in the same panel if they already exist, or the same stack as one of the panels that already exists.
DH-18347: Fixed bug with new panels not always showing initial content
Test Cases
Using the script:
Case 1
t3
t2
ort1
should load it for the first timeCase 2
t1
andt2
Case 3
Case 4
Case 5