DRAFT feat(domains): api domain options #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft pull request supplements the (internal) design doc for the API options. No real new functionality is implemented in this PR yet, just refactoring to add the options and show where they might go.
Note for reviewers: Take a look at the new
ApiOptsand the fields added to theRequeststruct (ApiOptsis a field too, any of the APIOpts can be overridden on a per-request basis). The items in ApiOpts have the potential to apply to every API request - for e.g. proxy and timeouts - while the added fields in requests are options that are (most likely to be) configured on a per-API basis.This is not complete, I have not added every option from the design doc yet. I was working through them and got thinking about the delineation between client and request options, and here we are.