Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: properties five, six and seven #195

Open
wants to merge 4 commits into
base: sc-feat/interop-testing-campaign
Choose a base branch
from

Conversation

0xDiscotech
Copy link

@0xDiscotech 0xDiscotech commented Jan 10, 2025

NOTE: The properties 6 and 7 will be marked as unit tests once all the other properties are covered. Will be done at the end so we don't mess up with the prop ids now.

CLOSES OPT-655

@0xDiscotech 0xDiscotech self-assigned this Jan 10, 2025
@0xDiscotech 0xDiscotech changed the title feat: property five feat: properties five, six and seven Jan 10, 2025
@0xDiscotech 0xDiscotech marked this pull request as ready for review January 10, 2025 21:01
@0xDiscotech 0xDiscotech requested a review from hexshire January 10, 2025 21:02
Copy link

linear bot commented Jan 10, 2025

@@ -177,4 +177,29 @@ contract ETHLiquidity_Test is CommonTest {
assertEq(address(ethLiquidity).balance, STARTING_LIQUIDITY_BALANCE);
assertEq(superchainWeth.balanceOf(address(ethLiquidity)), 0);
}

function testFuzz_mint_onlyCallabeBySuperchainWETH(address _caller, uint256 _amount) public {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing natspec on test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants