Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add myx adapter #43

Closed
wants to merge 3 commits into from
Closed

add myx adapter #43

wants to merge 3 commits into from

Conversation

marvin6en
Copy link
Contributor

No description provided.

@0xroll
Copy link
Contributor

0xroll commented Apr 16, 2024

hi @marvin6en thanks for the pr.

have some question :

  1. can i have the github repo link for building the subgraph
  2. does these cover the token balance changes in the lp pool due to traders' pnl ?
  3. are there lp tokens when user deposit into the pool? if yes, does it tracks token transfers? like user A provide LP -> transfer lp token to user B

@nitish-91
Copy link
Contributor

@marvin6en can you please follow readme to expose the function required, and use the input and output schema mentioned in it

@marvin6en
Copy link
Contributor Author

marvin6en commented May 4, 2024

hi @marvin6en thanks for the pr.

have some question :

  1. can i have the github repo link for building the subgraph
  2. does these cover the token balance changes in the lp pool due to traders' pnl ?
  3. are there lp tokens when user deposit into the pool? if yes, does it tracks token transfers? like user A provide LP -> transfer lp token to user B
  1. The subgraph url: https://subgraph-linea.myx.finance/subgraphs/name/myx-subgraph/graphql
  2. pnl of users does not have an impact on the number of pool lp's
  3. User deposits give the user lp tokens, But right now we really aren't tracking the transfer of user lp tokens

@marvin6en
Copy link
Contributor Author

marvin6en commented May 4, 2024

@marvin6en can you please follow readme to expose the function required, and use the input and output schema mentioned in it

I have confirmed that outputData.csv has been provided in the format you have requested

@0xroll
Copy link
Contributor

0xroll commented May 4, 2024

hey @marvin6en i mean the gh repo link

@marvin6en
Copy link
Contributor Author

hey @marvin6en i mean the gh repo link

It's not public yet.

@marvin6en
Copy link
Contributor Author

hey @0xroll Is there anything else we need to modify? We want to merge this PR as soon as possible

@0xroll
Copy link
Contributor

0xroll commented May 7, 2024

hi @marvin6en thanks for the pr.
have some question :

  1. can i have the github repo link for building the subgraph
  2. does these cover the token balance changes in the lp pool due to traders' pnl ?
  3. are there lp tokens when user deposit into the pool? if yes, does it tracks token transfers? like user A provide LP -> transfer lp token to user B
  1. The subgraph url: https://subgraph-linea.myx.finance/subgraphs/name/myx-subgraph/graphql
  2. pnl of users does not have an impact on the number of pool lp's
  3. User deposits give the user lp tokens, But right now we really aren't tracking the transfer of user lp tokens

actually we would need the transfers to be tracked. this captures the correct owner

also, any possibility of inviting me to your private subgraph repo?

@marvin6en
Copy link
Contributor Author

marvin6en commented May 7, 2024

hi @marvin6en thanks for the pr.
have some question :

  1. can i have the github repo link for building the subgraph
  2. does these cover the token balance changes in the lp pool due to traders' pnl ?
  3. are there lp tokens when user deposit into the pool? if yes, does it tracks token transfers? like user A provide LP -> transfer lp token to user B
  1. The subgraph url: https://subgraph-linea.myx.finance/subgraphs/name/myx-subgraph/graphql
  2. pnl of users does not have an impact on the number of pool lp's
  3. User deposits give the user lp tokens, But right now we really aren't tracking the transfer of user lp tokens

actually we would need the transfers to be tracked. this captures the correct owner

also, any possibility of inviting me to your private subgraph repo?

  1. If the transfer needs to be tracked, is it understandable to me that I need to give you all lp token holders
  2. Please provide an account that requires permission, and I will give you permission for our private warehouse.

@marvin6en marvin6en closed this May 7, 2024
@marvin6en marvin6en reopened this May 7, 2024
@marvin6en
Copy link
Contributor Author

hi @marvin6en thanks for the pr.
have some question :

  1. can i have the github repo link for building the subgraph
  2. does these cover the token balance changes in the lp pool due to traders' pnl ?
  3. are there lp tokens when user deposit into the pool? if yes, does it tracks token transfers? like user A provide LP -> transfer lp token to user B
  1. The subgraph url: https://subgraph-linea.myx.finance/subgraphs/name/myx-subgraph/graphql
  2. pnl of users does not have an impact on the number of pool lp's
  3. User deposits give the user lp tokens, But right now we really aren't tracking the transfer of user lp tokens

actually we would need the transfers to be tracked. this captures the correct owner
also, any possibility of inviting me to your private subgraph repo?

  1. If the transfer needs to be tracked, is it understandable to me that I need to give you all lp token holders
  2. Please provide an account that requires permission, and I will give you permission for our private warehouse.

Hello, can you help me? @0xroll

@0xroll
Copy link
Contributor

0xroll commented May 9, 2024

hi @marvin6en thanks for the pr.
have some question :

  1. can i have the github repo link for building the subgraph
  2. does these cover the token balance changes in the lp pool due to traders' pnl ?
  3. are there lp tokens when user deposit into the pool? if yes, does it tracks token transfers? like user A provide LP -> transfer lp token to user B
  1. The subgraph url: https://subgraph-linea.myx.finance/subgraphs/name/myx-subgraph/graphql
  2. pnl of users does not have an impact on the number of pool lp's
  3. User deposits give the user lp tokens, But right now we really aren't tracking the transfer of user lp tokens

actually we would need the transfers to be tracked. this captures the correct owner
also, any possibility of inviting me to your private subgraph repo?

  1. If the transfer needs to be tracked, is it understandable to me that I need to give you all lp token holders
  2. Please provide an account that requires permission, and I will give you permission for our private warehouse.

Hello, can you help me? @0xroll

  1. yes, the lp token represents who owns the liquidity, but if there is a staking/farming pool, then you need to get the "original" owner.

  2. can you invite me to the gh repo for the subgraph?

@marvin6en
Copy link
Contributor Author

@0xroll

  1. We have tracked the transfer of lp tokens in the subgraph, and now the data we provide is the latest holder
  2. We have invited you to our private subgraph repo. You can take a look and let us know if you have any questions.

@0xroll
Copy link
Contributor

0xroll commented May 15, 2024

@marvin6en saw the repo.

looks like currently the adapter is returning the lp address and lp balance?

we will need them to be on underlying token asset level :

eg : btc - usdc pair -> btc and usdc separately.

and sum up these underlying token balance, to get the total balance of each asset.

token balances will need bigINT (raw number)

Comment on lines +78 to +81
if (skip > 5000) {
skip = 0
b_start = snapshotsArrays[snapshotsArrays.length - 1].block + 1
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also curious on this part, why is this needed?

@nitish-91
Copy link
Contributor

@marvin6en can you please close this pr and raise again. We have added a pr template which will help in reducing review back and forth

@marvin6en marvin6en closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants