Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stargate adapter #68

Merged
merged 3 commits into from
May 6, 2024

Conversation

kyle-layerzero
Copy link
Contributor

No description provided.

Comment on lines 41 to 42
token_address: position.lpToken,
token_balance: BigInt(parseUnits(position.balance, 18)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be returning underlying token asset and raw token balance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-layerzero
the token_address should not be the lptoken. it should be the underlying token, and the balance should also be underlying token balance instead.

@0xroll
Copy link
Contributor

0xroll commented Apr 23, 2024

@kyle-layerzero thanks for the PR

please check the above, also the lp tokens has transfer events, is this accounted for?

user A LP -> transfer lp token to user B

please provide the subgraph gh repo as well

@kyle-layerzero
Copy link
Contributor Author

@0xroll invited you to https://github.com/LayerZero-Labs-External/linea-balances, let me know if you need a public repo

@0xroll
Copy link
Contributor

0xroll commented May 2, 2024

@kyle-layerzero i think the transfer events also have to be listened to as well?

https://lineascan.build/address/0xaad094f6a75a14417d39f04e690fc216f080a41a#writeContract#F23

not seeing it here :

image

@0xroll
Copy link
Contributor

0xroll commented May 6, 2024

this pr will only be tracking positions in farming contract.

@kyle-layerzero do make sure to share with your community that only staked positions will get points awarded!

@nitish-91 lets merge this

@nitish-91 nitish-91 merged commit 54820bf into delta-hq:main May 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants