feat(runtime): add a Cargo feature flag to enable the ffi API #26493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ffi
ext is difficult to cross compile (see denoland/rusty_v8#1640), so this PR moves it behind a Cargo feature flag for thedeno_runtime
crate (enabled by default).This adds some overhead to the runtime crate codebase as we must conditionally import some types and create a dummy deno_ffi extension so the snapshotting of the Deno namespace can work properly.
I'm not sure if the approach here is the best one or if this is something you are willing to merge, but I feel it would help a lot to get Deno to work on Android/iOS and also for cross compiling if the FFI features are not required