Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): add a Cargo feature flag to enable the ffi API #26493

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lucasfernog-crabnebula
Copy link
Contributor

The ffi ext is difficult to cross compile (see denoland/rusty_v8#1640), so this PR moves it behind a Cargo feature flag for the deno_runtime crate (enabled by default).

This adds some overhead to the runtime crate codebase as we must conditionally import some types and create a dummy deno_ffi extension so the snapshotting of the Deno namespace can work properly.

I'm not sure if the approach here is the best one or if this is something you are willing to merge, but I feel it would help a lot to get Deno to work on Android/iOS and also for cross compiling if the FFI features are not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant