merge SDK and packages.config references in discovery #11099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-merge-discovery
branch
from
cccddf7 to
569c19c
Compare
JamieMagee
previously approved these changes
Dec 27, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-merge-discovery
branch
from
569c19c to
1da3dd6
Compare
brbayes-msft
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a C# project to contain both SDK-style refernces (via
<PackageReference .../>elements) as well aspackages.config. Previously only thepackages.configstyle references would be considered if there were no SDK-style references.This PR allows both to exist and merges the results, including the
AdditionalFilesproperty.