Add bun package manager #11267
Open
Add bun package manager #11267
+342
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markhallen
force-pushed
the
markhallen/add-bun-package-manager
branch
from
c51a9e0 to
7396c30
Compare
Co-authored-by: Ashcon Partovi <[email protected]>
markhallen
force-pushed
the
markhallen/add-bun-package-manager
branch
from
7396c30 to
71ad8dd
Compare
|
Hey @markhallen I know you were not there yesterday but we discussed and agreed that bun will be implemented as it's own ecosystem independent of npm & yarn. |
kbukum1
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Is there a reason we recreated package manager for npm, pnpm and yarn? There in PackageManagerHelper normally?
kbukum1
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Is there a reason we recreated package manager for npm, pnpm and yarn? There in PackageManagerHelper normally?
kbukum1
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Is there a reason we recreated package manager for npm, pnpm and yarn? There in PackageManagerHelper normally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
As a first step towards adding support for Bun we are adding the
BunPackageManagerclass and extracting package managers into their own files.bun.lock#11209 in digestible PRs.bun#6528Anything you want to highlight for special attention from reviewers?
For wider context you can check #11209 or #11248
How will you know you've accomplished your goal?
The old specs should pass after the file structure changes and the new specs should pass for the new package manager.
Checklist