Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependabot php version from 7.4 to 8.1. #11270

Closed
wants to merge 1 commit into from

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Jan 10, 2025

What are you trying to accomplish?

upgrading dependabot's php version from 7 to 8

As php 7 is getting obsolete from the market, I hope this is the right time to upgrade the dependabot php version from 7 to 8

Monolog 3.6 stop supporting php 7

this issue we have found out in out our internal e2e testing

Recreated the same here

Anything you want to highlight for special attention from reviewers?

work is not completed, this is a discussion PR

How will you know you've accomplished your goal?

Not yet completed, need to check with @abdulapopoola and team, about this changes.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner January 10, 2025 14:26
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label Jan 10, 2025
@thavaahariharangit thavaahariharangit marked this pull request as draft January 10, 2025 14:32
@vintagesucks
Copy link

What about #6506?

@thavaahariharangit
Copy link
Contributor Author

What about #6506?

Thanks @vintagesucks , I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants