Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated amino codec and GetSignBytes methods #1251

Closed
wants to merge 84 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
e43b4cf
fix: fix account creation of dtag request sender
dadamu Sep 28, 2023
cd3076e
chore: update changeset entry
dadamu Sep 28, 2023
57de5d3
fix: prevent save profile without account
dadamu Sep 28, 2023
ce5b489
chore: update dependencies
dadamu Sep 22, 2023
c37cb28
chore: update ibc to v8 from v7
dadamu Sep 22, 2023
ea2d2bc
chore: update cosmos-sdk/store package path
dadamu Sep 22, 2023
f62e11a
chore: update cosmos-sdk/evidence package path
dadamu Sep 22, 2023
e5ae742
chore: update cosmos-sdk/feegrant package path
dadamu Sep 22, 2023
703763e
chore: update cosmos-sdk/upgrade package path
dadamu Sep 22, 2023
98f3622
chore: move x/capability to ibc-go and remove legacy gov clients of x…
dadamu Sep 22, 2023
8c3f889
chore: run go mod tidy
dadamu Sep 22, 2023
761a13d
chore: update cometbft/libs/log path
dadamu Sep 22, 2023
6bdb055
chore: update sdk/types.Int to math.Int
dadamu Sep 22, 2023
ea888e2
chore: update proto builder and generate new proto files
dadamu Sep 22, 2023
da8d36d
chore: update cosmos-db and app
dadamu Sep 22, 2023
4f65756
chore: remove unused upgrades
dadamu Sep 22, 2023
45b9e71
chore: update command
dadamu Sep 22, 2023
2fed98b
chore: update sdk.Int into math.Int
dadamu Sep 25, 2023
82a8448
chore: update app config
dadamu Sep 25, 2023
4d1d85e
chore: remove non begin/end blocker modules from order
dadamu Sep 25, 2023
1c1f2b8
chore: update sdk.StoreDecoderRegistry into simtypes
dadamu Sep 25, 2023
c57817d
chore: remove module since it is not accepted
dadamu Sep 25, 2023
ac0609c
chore: update cosmos-sdk/store/types package path
dadamu Sep 26, 2023
b6ce4f5
fix: revert supply math and cosmosmath path
dadamu Sep 26, 2023
29c0d7c
chore: update sdk.NewKVStoreKey package path to stortypes
dadamu Sep 26, 2023
ccd20db
chore: update sdk.NewTransientStoreKey package path to storetypes
dadamu Sep 26, 2023
669f4a5
chore: remove deprecated codec register for x/gov and /authz
dadamu Sep 26, 2023
7e48226
chore: define WasmMsg for legacy wasm encoder
dadamu Sep 26, 2023
25670ba
chore: update store.NewCommitMultiStore parameters
dadamu Sep 26, 2023
16b9eb4
chore: update authtypes.AccountI into sdk.AccountI
dadamu Sep 26, 2023
c16cc49
chore: update go-metrics package path
dadamu Sep 26, 2023
3103b7a
chore: update appParams.GetOrGenerate parameters of simulation operation
dadamu Sep 26, 2023
203d6a7
chore: update simd keepers of x/supply
dadamu Sep 27, 2023
4276672
chore: update testing tools
dadamu Sep 27, 2023
342a8bb
fix: add missing dependencies
dadamu Sep 27, 2023
c651e27
fix: add missing dependencies in app
dadamu Sep 27, 2023
b7482a8
chore: update subspaces ante
dadamu Sep 27, 2023
64dd599
chore: update subspaces authz
dadamu Sep 27, 2023
9a8d6bc
chore: update subspaces legacy
dadamu Sep 27, 2023
76bfb8a
chore: update subspaces simd expected keepers
dadamu Sep 27, 2023
cf8ec81
chore: update tokenfactory simd expected keepers
dadamu Sep 27, 2023
276d2e8
fix: add missing profiles legacy dependencies
dadamu Sep 27, 2023
88fd20b
build(deps): bump cosmos-sdk to 0.50.0-rc.1
dadamu Sep 27, 2023
d40c2b8
chore: update subspaces legacy simd expected keepers
dadamu Sep 27, 2023
777fd1a
chore: update tokenfactory MintingRestrictionFn dependencies
dadamu Sep 27, 2023
5823c66
chore: update subspaces ante simd expected keepers
dadamu Sep 27, 2023
bf854df
chore: update test suite simd keepers setting
dadamu Sep 27, 2023
29f36b3
chore: refresh mock keepers by mockgen
dadamu Sep 27, 2023
10ff0a8
fix: remove non-existing command
dadamu Sep 27, 2023
c8332f4
chore: update app links sign command
dadamu Sep 27, 2023
930b596
chore: update and fix chain links sign command
dadamu Sep 27, 2023
1fa16bf
chore: update ibctesting tool
dadamu Sep 27, 2023
b859709
build(deps): update cosmos-sdk buf version
dadamu Sep 27, 2023
f167dc1
chore: ignore .dot files
dadamu Sep 27, 2023
9c4a992
test: fix create chain link json test
dadamu Sep 27, 2023
c6e8012
chore: add legacy amino registraction
dadamu Sep 27, 2023
2cc6ed0
revert: recover subpsaces ante in app
dadamu Sep 27, 2023
4e8877d
chore(deps): update gin
dadamu Sep 27, 2023
2b11410
fix: move msg types into msg_server
dadamu Sep 27, 2023
7337be5
chore: set ibc-go capability module and keeper
dadamu Sep 27, 2023
bf1bed2
fix: remove legacytx register amino codec
dadamu Sep 27, 2023
26cd563
fix: avoid from using testing app.GetKey in constructor
dadamu Sep 27, 2023
57ba7f3
fix: fix begin blocker order and register missing runtime module to o…
dadamu Sep 27, 2023
9f2500b
test: add finalize block state in sim app export test
dadamu Sep 27, 2023
4f95b6b
test: set missing account number to module account
dadamu Sep 27, 2023
9aa9841
chore: update make encoding config
dadamu Sep 27, 2023
4936fd9
test: apply ibc-go testing tool
dadamu Sep 28, 2023
d05fcff
test: customize ibc testing tool for desmos
dadamu Sep 28, 2023
3ffbc4c
test: update wasm any resolver test
dadamu Sep 28, 2023
8a4abed
test: fix missing account number on profile
dadamu Sep 28, 2023
fafc67a
chore: add capability keeper seal
dadamu Sep 28, 2023
68287ee
build(deps): bump go to 1.21
dadamu Sep 28, 2023
4844530
chore: remove deprecated wrap sdk context methods
dadamu Sep 28, 2023
f0a7091
chore: add v7 upgrade
dadamu Sep 28, 2023
2e330f9
chore: fix lint
dadamu Sep 28, 2023
1b0963c
test: use desmos ibc setting on profiles tests
dadamu Sep 28, 2023
a7f1ff3
revert: register ibc types manually
dadamu Sep 28, 2023
cb25f94
test: update ibc relay timeout height
dadamu Sep 28, 2023
0b4cb2e
chore: fix lint
dadamu Sep 28, 2023
fb8b314
docs: update Swagger definition
dadamu Sep 28, 2023
3d5e16a
ci: update golang version of docker builder
dadamu Sep 28, 2023
115f6ba
Merge branch 'paul/DCD-415/bump-cosmos-sdk-to-0.50.0' of github.com:d…
dadamu Sep 28, 2023
15d5dfe
build(deps): bumps ledger desmos go to v0.13.0-desmos
dadamu Sep 28, 2023
763c8fd
chore: remove deprecated amino codec and signbytes method
dadamu Sep 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: fix
module: x/profiles
pull_request: 1250
description: Fix missing account number of account creation
backward_compatible: true
date: 2023-09-28T08:12:05.365508338Z
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mutest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Run mutation tests 🧪
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-chain-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Install Desmos 🔧
run: make clean install
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Unshallow
run: git fetch --prune --unshallow --tags --force
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
# - name: Setup Go 🧰
# uses: actions/setup-go@v4
# with:
# go-version: '1.19'
# go-version: '1.21'
#
# - name: Build the binary 🏭
# run: |
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
# - name: Setup Go 🧰
# uses: actions/setup-go@v4
# with:
# go-version: '1.19'
# go-version: '1.21'
#
# - name: Compute diff 📜
# uses: technote-space/[email protected]
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
# - name: Setup Go 🧰
# uses: actions/setup-go@v4
# with:
# go-version: '1.19'
# go-version: '1.21'
#
# - name: Build the binary 🏭
# run: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/sims.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Build 🔨
run: make build
Expand All @@ -43,7 +43,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Install runsim 🏃
run: export GO111MODULE="on" && go install github.com/cosmos/tools/cmd/[email protected]
Expand All @@ -64,7 +64,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Display go version 🛂
run: go version
Expand All @@ -49,7 +49,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down Expand Up @@ -220,7 +220,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down Expand Up @@ -308,7 +308,7 @@ jobs:
- name: Setup Go 🧰
uses: actions/setup-go@v4
with:
go-version: '1.19'
go-version: '1.21'

- name: Compute diff 📜
uses: technote-space/[email protected]
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ sim_log_file
*.box
*.log
vagrant
*.dot

# IDE
.idea/
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ update-deps-types:
###############################################################################
### Protobuf ###
###############################################################################
protoVer=0.11.6
protoVer=0.14.0
protoImageName=ghcr.io/cosmos/proto-builder:$(protoVer)
protoImage=$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace --user $(shell id -u):$(shell id -g) $(protoImageName)

Expand Down
15 changes: 8 additions & 7 deletions app/ante.go
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
package app

import (
corestoretypes "cosmossdk.io/core/store"
"cosmossdk.io/errors"
storetypes "github.com/cosmos/cosmos-sdk/store/types"
sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
"github.com/cosmos/cosmos-sdk/x/auth/ante"
ibcante "github.com/cosmos/ibc-go/v7/modules/core/ante"
ibckeeper "github.com/cosmos/ibc-go/v7/modules/core/keeper"
ibcante "github.com/cosmos/ibc-go/v8/modules/core/ante"
ibckeeper "github.com/cosmos/ibc-go/v8/modules/core/keeper"

subspaceante "github.com/desmos-labs/desmos/v6/x/subspaces/ante"
subspacesante "github.com/desmos-labs/desmos/v6/x/subspaces/ante"
subspaceskeeper "github.com/desmos-labs/desmos/v6/x/subspaces/keeper"

wasmkeeper "github.com/CosmWasm/wasmd/x/wasm/keeper"
Expand All @@ -23,7 +23,7 @@ type HandlerOptions struct {

IBCkeeper *ibckeeper.Keeper
SubspacesKeeper subspaceskeeper.Keeper
TxCounterStoreKey storetypes.StoreKey
TxCounterStoreKey corestoretypes.KVStoreService
WasmConfig *wasmTypes.WasmConfig
}

Expand Down Expand Up @@ -58,8 +58,9 @@ func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) {
ante.NewTxTimeoutHeightDecorator(),
ante.NewValidateMemoDecorator(options.AccountKeeper),
ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper),
subspaceante.NewDeductFeeDecorator(
ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker), options.AccountKeeper, options.BankKeeper, options.SubspacesKeeper, options.TxFeeChecker),
subspacesante.NewDeductFeeDecorator(
ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker), options.AccountKeeper, options.BankKeeper, options.SubspacesKeeper, options.TxFeeChecker,
),
// SetPubKeyDecorator must be called before all signature verification decorators
ante.NewSetPubKeyDecorator(options.AccountKeeper),
ante.NewValidateSigCountDecorator(options.AccountKeeper),
Expand Down
Loading