Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue when the top level domain was trimmed #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beliaev-maksim
Copy link
Member

Take simple example

'https://canonical.jfrog.io'.rstrip("/artifactory")

results in

'https://canonical.jfrog.'

@@ -2463,7 +2463,7 @@ def _get_all(self, lazy: bool, url=None, key="name", cls=None):
"return: A list of found objects
"""
if cls is Project:
request_url = self.drive.rstrip("/artifactory") + url
request_url = self.drive.replace("/artifactory", "") + url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be something like rexegp? The replace doesn't care if it meats the string at the middle and we care only about the tail here

Suggested change
request_url = self.drive.replace("/artifactory", "") + url
request_url = re.sub(r"/artifactory$", "", self.drive) + url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants