Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bifurcate image cards in imageScan codeScan and manifestScan #500

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat: bifurcate image cards in imageScan codeScan and manifestScan #500

wants to merge 11 commits into from

Conversation

arunjaindev
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

AbhishekA1509
AbhishekA1509 requested changes Jan 8, 2025
View reviewed changes
src/Assets/Icon/ic-shield-check.svg Outdated Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/SecurityDetailsCards.tsx Outdated Show resolved Hide resolved
src/Shared/Components/Security/Vulnerabilities/Vulnerabilities.tsx Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/securityCard.scss Outdated Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/securityCard.scss Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/SecurityDetailsCards.tsx Outdated
const imageScanToolId =
imageScan?.vulnerability?.list?.[0].scanToolName === 'TRIVY' ? SCAN_TOOL_ID_TRIVY : SCAN_TOOL_ID_CLAIR
const codeScanToolId = codeScan?.scanToolName === 'TRIVY' ? SCAN_TOOL_ID_TRIVY : SCAN_TOOL_ID_CLAIR
const manifestScanToolId = kubernetesManifest?.scanToolName === 'TRIVY' ? SCAN_TOOL_ID_TRIVY : SCAN_TOOL_ID_CLAIR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Ideally this should be parsed in service?

src/Shared/Components/Security/SecurityDetailsCards/SecurityDetailsCards.tsx Outdated Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/SecurityCard.tsx Outdated Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/SecurityCard.tsx Outdated Show resolved Hide resolved
src/Shared/Components/Security/SecurityDetailsCards/SecurityCard.tsx Show resolved Hide resolved
AbhishekA1509
AbhishekA1509 previously approved these changes Jan 8, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhishekA1509 AbhishekA1509 AbhishekA1509 left review comments

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunjaindev @AbhishekA1509