Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IDX): remove RUN_CI var #274

Merged
merged 10 commits into from
Jun 27, 2024
Merged

chore(IDX): remove RUN_CI var #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c048615
cleanup(IDX): remove RUN_CI var
cgundy Jun 27, 2024
e002e21
IDX GitHub Automation
Jun 27, 2024
2a2f6e8
remove
cgundy Jun 27, 2024
85e7388
IDX GitHub Automation
Jun 27, 2024
3a5d4bb
update
cgundy Jun 27, 2024
d98646d
IDX GitHub Automation
Jun 27, 2024
c21436b
chore(IDX): allow manual trigger for container autobuild (#275)
cgundy Jun 27, 2024
698f10b
Merge branch 'mirroring' into remove-run-ci-var
cgundy Jun 27, 2024
337deaf
IDX GitHub Automation
Jun 27, 2024
18e4c6d
Merge branch 'mirroring' into remove-run-ci-var
cgundy Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows-source/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ anchors:
container:
<<: *image
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
before-script: &before-script
name: Before script
id: before-script
Expand Down Expand Up @@ -124,7 +123,7 @@ jobs:
name: Bazel Test Darwin x86-64
timeout-minutes: 120
# TODO: enable once we have more macos runners
if: ${{ vars.RUN_CI == 'true' && github.event_name == 'schedule' }}
if: ${{ github.event_name == 'schedule' }}
runs-on:
labels: macOS
steps:
Expand Down Expand Up @@ -198,7 +197,6 @@ jobs:
name: Python CI Tests
runs-on: ubuntu-latest
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
steps:
- <<: *checkout
- <<: *python-setup
Expand All @@ -217,7 +215,7 @@ jobs:
build-ic:
name: Build IC
<<: *dind-large-setup
if: ${{ vars.RUN_CI == 'true' && github.event_name != 'merge_group' }}
if: ${{ github.event_name != 'merge_group' }}
steps:
- <<: *checkout
- <<: *before-script
Expand Down Expand Up @@ -248,7 +246,6 @@ jobs:
name: Build Determinism
runs-on: ubuntu-latest
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
needs: [build-ic, bazel-test-all]
strategy:
matrix:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows-source/ci-pr-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,12 @@ anchors:
container:
<<: *image
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
dind-large-setup: &dind-large-setup
runs-on:
group: dind-large
container:
<<: *image
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
before-script: &before-script
name: Before script
id: before-script
Expand Down
1 change: 0 additions & 1 deletion .github/workflows-source/release-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ anchors:
container:
<<: *image
timeout-minutes: 180 # 3 hours
if: ${{ vars.RUN_CI == 'true' }}
checkout: &checkout
name: Checkout
uses: actions/checkout@v4
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows-source/schedule-daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ anchors:
container:
<<: *image
timeout-minutes: 120
if: ${{ vars.RUN_CI == 'true' }}
checkout: &checkout
name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -70,7 +69,7 @@ jobs:
<<: *dind-large-setup
timeout-minutes: 720 # 12 hours
# TODO: disable in GitLab before enabling here
if: ${{ vars.RUN_CI == 'true' && false }}
if: ${{ && false }}
strategy:
matrix:
targets: ["//rs/crypto/...", "//rs/state_manager/..."]
Expand All @@ -95,7 +94,7 @@ jobs:
<<: *dind-large-setup
timeout-minutes: 120
# TODO: enable when zh1 is active again
if: ${{ vars.RUN_CI == 'true' && false }}
if: ${{ false }}
steps:
- <<: *checkout
- <<: *before-script
Expand Down Expand Up @@ -123,7 +122,6 @@ jobs:
name: Bazel Test NNS Nightly
<<: *dind-large-setup
timeout-minutes: 20
if: ${{ vars.RUN_CI == 'true' }}
steps:
- <<: *checkout
- <<: *before-script
Expand All @@ -142,7 +140,6 @@ jobs:
name: Bazel System Test Benchmarks
<<: *dind-large-setup
timeout-minutes: 480
if: ${{ vars.RUN_CI == 'true' }}
steps:
- <<: *checkout
- <<: *before-script
Expand Down
1 change: 0 additions & 1 deletion .github/workflows-source/schedule-hourly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ anchors:
container:
<<: *image
timeout-minutes: 120
if: ${{ vars.RUN_CI == 'true' }}
checkout: &checkout
name: Checkout
uses: actions/checkout@v4
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -89,7 +88,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
name: Bazel Build All Config Check
steps:
- name: Checkout
Expand All @@ -113,7 +111,7 @@ jobs:
name: Bazel Test Darwin x86-64
timeout-minutes: 120
# TODO: enable once we have more macos runners
if: ${{ vars.RUN_CI == 'true' && github.event_name == 'schedule' }}
if: ${{ github.event_name == 'schedule' }}
runs-on:
labels: macOS
steps:
Expand Down Expand Up @@ -167,7 +165,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -191,7 +188,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -212,7 +208,6 @@ jobs:
name: Python CI Tests
runs-on: ubuntu-latest
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -240,7 +235,7 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' && github.event_name != 'merge_group' }}
if: ${{ github.event_name != 'merge_group' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -276,7 +271,6 @@ jobs:
name: Build Determinism
runs-on: ubuntu-latest
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
needs: [build-ic, bazel-test-all]
strategy:
matrix:
Expand Down Expand Up @@ -333,7 +327,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -369,7 +362,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ci-pr-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 90
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -55,7 +54,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -88,7 +86,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 30
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/container-base-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
name: Build Base Container Image
runs-on: ubuntu-latest
timeout-minutes: 45
if: ${{ vars.RUN_CI == 'true' }}
strategy:
matrix:
include:
Expand Down Expand Up @@ -107,7 +106,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
needs: [build-base-image]
if: ${{ vars.RUN_CI == 'true' && github.ref_name == 'master' }}
if: ${{ github.ref_name == 'master' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 180 # 3 hours
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -55,7 +54,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 180 # 3 hours
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -78,7 +76,6 @@ jobs:
group: dind-large
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
if: ${{ vars.RUN_CI == 'true' }}
timeout-minutes: 90
steps:
- name: Checkout
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/schedule-daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 720 # 12 hours
# TODO: disable in GitLab before enabling here
if: ${{ vars.RUN_CI == 'true' && false }}
if: ${{ && false }}
strategy:
matrix:
targets: ["//rs/crypto/...", "//rs/state_manager/..."]
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 120
# TODO: enable when zh1 is active again
if: ${{ vars.RUN_CI == 'true' && false }}
if: ${{ false }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -114,7 +114,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 20
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -139,7 +138,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 480
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/schedule-hourly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 120
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -49,7 +48,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 120
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -73,7 +71,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 120
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/schedule-weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
container:
image: ghcr.io/dfinity/ic-build@sha256:b7d870287df55b9972ed285fe1a9792cb81243523400d83d491f3ee149e8d47c
timeout-minutes: 60 # 1 hour
if: ${{ vars.RUN_CI == 'true' }} # needed to avoid running on public dfinity org until published
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down