Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Split the user ingress artifacts and the artifacts coming from P2P #3419

Merged
merged 13 commits into from
Jan 15, 2025
Merged

chore: Split the user ingress artifacts and the artifacts coming from P2P #3419

merged 13 commits into from
Jan 15, 2025

Conversation

rumenov
Copy link
Member

@rumenov rumenov commented Jan 13, 2025 •
edited
Loading

The PR improves the API of the abortable broadcast crate.

ubuntu@devenv-container:/ic/rs/p2p/artifact_manager$ bazel test :all --runs_per_test=100 
INFO: Invocation ID: ae9b1dd3-3e96-4a1a-955b-fa628bf3de14
INFO: Analyzed 2 targets (0 packages loaded, 19 targets configured).
INFO: Found 1 target and 1 test target...
INFO: Elapsed time: 2.290s, Critical Path: 1.12s
INFO: 103 processes: 202 linux-sandbox.
INFO: Build completed successfully, 103 total actions
//rs/p2p/artifact_manager:artifact_manager_test                          PASSED in 0.1s
  Stats over 100 runs: max = 0.1s, min = 0.0s, avg = 0.0s, dev = 0.0s

@rumenov rumenov changed the title . rm sender Jan 14, 2025
@rumenov rumenov changed the title rm sender chore: rm sender Jan 14, 2025
@github-actions github-actions bot added the chore label Jan 14, 2025
@rumenov rumenov changed the title chore: rm sender chore: Split the user ingress artifacts and the artifacts coming from P2P Jan 14, 2025
@rumenov rumenov marked this pull request as ready for review January 14, 2025 09:20
@rumenov rumenov requested review from a team as code owners January 14, 2025 09:20
@rumenov rumenov requested a review from DSharifi January 14, 2025 09:21
DSharifi
DSharifi approved these changes Jan 14, 2025
View reviewed changes
rs/p2p/artifact_manager/src/lib.rs Outdated Show resolved Hide resolved
@rumenov rumenov requested a review from DSharifi January 15, 2025 15:01
@rumenov rumenov enabled auto-merge January 15, 2025 15:02
@rumenov rumenov added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit 5cce4f5 Jan 15, 2025
28 checks passed
@rumenov rumenov deleted the rumenov/rmtxdse branch January 15, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSharifi DSharifi DSharifi approved these changes

@marko-k0 marko-k0 marko-k0 approved these changes

Assignees
No one assigned
Labels
chore @consensus @idx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumenov @marko-k0 @DSharifi