test(nns): Add a test for NNS proposals being adopted in the golden state #3461
Conversation
aterga
changed the base branch from
master
to
arshavir/add-nns-governance-test-function-adopt_proposal
aterga
force-pushed
the
arshavir/add-nns-governance-test-function-adopt_proposal
branch
from
a577397 to
48cef74
Compare
| true, | ||
| ); | ||
|
|
||
| // Step 3: Verify result(s): In a short while, the canister should be running the new code. |
There was a problem hiding this comment.
I would say that this is part of setting up the world (step 1). At this point, we are not yet verifying the code under test. (We are merely installing adopt_proposal so that we can run the code under test, namely, proposal execution, specifically for network economics.)
| // Phase I. Upgrade NNS Governance to a test-only version (using a super powerful neuron) that | ||
| // allows adopting any proposal by calling adopt_proposal. |
There was a problem hiding this comment.
| // Phase I. Upgrade NNS Governance to a test-only version (using a super powerful neuron) that | |
| // allows adopting any proposal by calling adopt_proposal. | |
| // Step 1.2: Upgrade NNS Governance to a test-only version, which | |
| // has adopt_proposal method. |
| adopt_proposal(&state_machine, proposal_id).unwrap(); | ||
|
|
||
| nns_wait_for_proposal_execution(&state_machine, proposal_id.id); |
There was a problem hiding this comment.
THIS is where the code under test gets executed.
There was a problem hiding this comment.
Well, you're not wrong.
But from another perspective, this is not a test for adopt_proposal (that's sufficiently tested using unit tests).
The point of this test is, as I tried to explain in the PR description, to enable humans to answer the question:
- Is a given proposal submitted in the system from which the golden state snapshot was taken going to be executed successfully, assuming the NNS community adopts it?
- Is the proposal going to have the expected / desired effect?
There was a problem hiding this comment.
I'll also explain this in a doc comment for this test.
aterga
force-pushed
the
arshavir/validate-nns-proposal-134803
branch
from
69a4ecf to
fa409b3
Compare
This PR adds a new target
//rs/nns/integration_tests:test_proposal_with_golden_nns_statethat allows testing the effect of a proposal being adopted in a system that has the golden state installed. While this target is designed for manual experiments, it is covered by a nightly test to avoid bit rot.< Previous PR |