feat(portfolio): new utility to get top projects for the ProjectsCard #6159
+216
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Portfolio page displays a list of projects that behaves differently based on specific rules.
The
getTopProjects
function encapsulates the following logic:stakeInUsd
. If ICP is present, it should be the first item in the list.Changes
compareProjectsByUsdBalance
compareIcpFirst
andcompareByProjectTitle
from staking.utils to build the sorting comparator.getTopProjects
Tests
getTopProjects
Todos
Not necessary.