Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display voting power in red when rewards are reduced #6161

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Display voting power in red when rewards are reduced #6161

merged 3 commits into from
Jan 15, 2025
+62 −1

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Jan 14, 2025 •
edited
Loading

Motivation

To highlight missing rewards, we display voting power in red when rewards are reduced.

Changes

  • Update styling when deciding vp is less than potential.

Tests

  • Added.
  • Tested locally.
image image

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review January 14, 2025 16:03
@mstrasinskis mstrasinskis requested a review from a team as a code owner January 14, 2025 16:03
yhabib
yhabib approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left non-blocking comments

frontend/src/tests/lib/components/neuron-detail/NnsNeuronVotingPowerSection.spec.ts Outdated Show resolved Hide resolved
frontend/src/lib/components/neuron-detail/NnsNeuronVotingPowerSection.svelte Show resolved Hide resolved
@mstrasinskis mstrasinskis added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit e3bfaa4 Jan 15, 2025
32 checks passed
@mstrasinskis mstrasinskis deleted the vp-in-red branch January 15, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @yhabib