Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upgrader): new stable memory layout #474

Merged
merged 17 commits into from
Jan 14, 2025
Merged

feat(upgrader): new stable memory layout #474

merged 17 commits into from
Jan 14, 2025

Conversation

mraszyk
Copy link
Collaborator

@mraszyk mraszyk commented Jan 10, 2025 •
edited
Loading

This PR introduces a new stable memory layout for the upgrader:

  • the bucket size is reduced from the default 8MiB to 1MiB;
  • the target canister id is bundled with the disaster recovery state (and a new stable memory version field) into a single stable memory region.

The above two changes reduce the default upgrader stable memory footprint from 3 x 8MiB down to 2 x 1MiB.

mraszyk added 17 commits January 10, 2025 17:52
@mraszyk
fix(upgrader): only retain requests from current committee members
1a39d85
@mraszyk
feat(upgrader): new stable memory layout
d74ab4c
@mraszyk
comment
9d30bb2
@mraszyk
visibility
ed5c1c5
@mraszyk
refactor
93aa392
@mraszyk
test stable memory length in the latest layout
c5c3c23
@mraszyk
harden tests
14b7218
@mraszyk
harden tests
3cbef56
@mraszyk
feat(upgrader): optimize stable memory serialization
5cd0c3e
@mraszyk
larger committee
4682df3
@mraszyk
Merge branch 'mraszyk/upgrader-committee-pending-requests' into mrasz…
05c6359 
…yk/large-upgrader-test-data
@mraszyk
more large requests
ae9d800
@mraszyk
Merge branch 'mraszyk/large-upgrader-test-data' into mraszyk/upgrader…
e120305 
…-stable-memory-migration
@mraszyk
clear stable memory
3c66653
@mraszyk
test stable memory growth after migration
9cfe76e
@mraszyk
Merge branch 'main' into mraszyk/upgrader-stable-memory-migration
30afad1
@mraszyk
Merge branch 'main' into mraszyk/upgrader-stable-memory-migration
8a11cf3
@mraszyk mraszyk marked this pull request as ready for review January 13, 2025 21:15
@mraszyk mraszyk requested a review from a team as a code owner January 13, 2025 21:15
olaszakos
olaszakos approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@olaszakos olaszakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraszyk mraszyk merged commit 62b3a59 into main Jan 14, 2025
47 checks passed
@mraszyk mraszyk deleted the mraszyk/upgrader-stable-memory-migration branch January 14, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaszakos olaszakos olaszakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @olaszakos