-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display type and definitions in data item selector (DHIS2-14774) #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Implement async request for human readable expressions for some types.
edoardo
force-pushed
the
feat/info-data-item-selector-DHIS2-14774
branch
from
November 11, 2024 11:08
d0edd3f
to
3edb797
Compare
The href is not returned by this api.
This is temporary to avoid the whole modal content to not load.
…-selector-DHIS2-14774
Pass dataType to InfoTable so it's possibile to show/hide different parts of the common table.
edoardo
changed the title
feat: implement info popover for dimensions (DHIS2-14774)
feat: implement info popover for data dimensions (DHIS2-14774)
Jan 8, 2025
edoardo
changed the title
feat: implement info popover for data dimensions (DHIS2-14774)
feat: display type and definitions in data item selector (DHIS2-14774)
Jan 8, 2025
janhenrikoverland
approved these changes
Jan 9, 2025
dhis2-bot
added a commit
that referenced
this pull request
Jan 9, 2025
# [26.10.0](v26.9.6...v26.10.0) (2025-01-09) ### Features * display type and definitions in data item selector (DHIS2-14774) ([#1713](#1713)) ([27f4b65](27f4b65))
🎉 This PR is included in version 26.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14774
Relates to dhis2/data-visualizer-app#3274
Key features
Description
This popover shows informations about each data item.
The information shown depends on the item's type.
TODO
Screenshots