Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-18836] show 'Profile' instead of 'False' during loading #3938

Merged

Conversation

eirikhaugstulen
Copy link
Contributor

Summary:

  • Display correct title when profile widget is loading

@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner January 15, 2025 00:41
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM! Could you link the PR to a Jira ticket? Thanks!

@eirikhaugstulen eirikhaugstulen changed the title fix: show 'Profile' instead of 'False' during loading fix: [DHIS2-18836] show 'Profile' instead of 'False' during loading Jan 15, 2025
Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.4,2.40.7,2.39.9 versions

@eirikhaugstulen eirikhaugstulen merged commit 70aa7cc into master Jan 15, 2025
42 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/display-correct-profile-widget-title-on-load branch January 15, 2025 14:42
dhis2-bot added a commit that referenced this pull request Jan 15, 2025
## [101.21.5](v101.21.4...v101.21.5) (2025-01-15)

### Bug Fixes

* [DHIS2-18836] show 'Profile' instead of 'False' during loading ([#3938](#3938)) ([70aa7cc](70aa7cc))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.21.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants