feat: fetch superset base url with system settings #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3181.dashboard.netlify.dhis2.org |
HendrikThePendric
changed the base branch from
master
to
feat/embedded-superset-dashboards-DHIS2-17891
|
HendrikThePendric
merged commit dd26c38
into
feat/embedded-superset-dashboards-DHIS2-17891
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fetch
keyEmbeddedDashboardsEnabledwhen I fetch the system settings and iftrueI also proceed to fetch thesupersetBaseUrl. I'm doing so using a regular fetch and take into account that in productionbaseUrlcould be.., which I think could be problematic for thefetch().