Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use getAllPrincipals #19703

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: don't use getAllPrincipals #19703

merged 2 commits into from
Jan 17, 2025
+4 −11

Conversation

netroms
Copy link
Contributor

@netroms netroms commented Jan 17, 2025 •
edited
Loading

Problem

The session registry getAllPrincipals() is not compatible with the Redis backed session store, since it does not store session by principal.

Fix

Create the principal from the user instead of iterating through the list obtained via the session store.

JIRA: DHIS2-18460

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 17, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@netroms netroms merged commit 1270fac into 2.41 Jan 17, 2025
15 checks passed
@netroms netroms deleted the DHIS2-18460_getAllPrincipals_fix_2.41 branch January 17, 2025 14:34
@netroms netroms mentioned this pull request Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-mackessy david-mackessy david-mackessy approved these changes

@vietnguyen vietnguyen vietnguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroms @vietnguyen @david-mackessy