Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci and others v2 #7

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Add ci and others v2 #7

merged 8 commits into from
Aug 14, 2024

Conversation

gabriel-tessier
Copy link
Member

No description provided.

@gabriel-tessier gabriel-tessier requested a review from tb102122 July 13, 2024 07:40
@gabriel-tessier
Copy link
Member Author

gabriel-tessier commented Jul 13, 2024

@tb102122

The previous PR had too much conflicts I created a new branch from master and cherry pick your changes.
Can you review the commit and confirm that no code was lost.

I left the other PR open until you check and confirm that all is here.

@gabriel-tessier
Copy link
Member Author

@tb102122
Can you check also for what you mention in the Issue #2:

I did one important change in the project.toml to support 3.12 and remove 3.7 support please migrate that as well

@tb102122 tb102122 mentioned this pull request Jul 15, 2024
@tb102122
Copy link
Contributor

@tb102122 Can you check also for what you mention in the Issue #2:
The updates are done.

Copy link
Contributor

@tb102122 tb102122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you like to remove the publishing step or keep it?

poetry install
- name: Build and Publish package
run: |
poetry config pypi-token.pypi ${{ secrets.your-api-token }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still needs to be updated @gabriel-tessier

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tb102122
I submitted an organization called diagrams-web on pypi it's still in pending state from more than 2 weeks.
I didn't want to publish it on my own account and transfer it later as I want to have the package on the organization from the beginning.

diagrams-web Community Request Submitted

Submitted Jul 13, 2024

But as it take more time than I expected for Pypi to approve, I will publish it on my own account.
About the py-publish.yml, let's keep this as it and wait to have the information for the organization to set teh secrets.

You will receive an invitation for the organization as soon as it get approved.

@gabriel-tessier gabriel-tessier merged commit 9befbd4 into master Aug 14, 2024
7 checks passed
@tb102122 tb102122 deleted the add_ci_and_others_v2 branch August 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants