Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict memory-analyzer build to Linux x86_64/i386 #7958

Merged

Conversation

tautschnig
Copy link
Collaborator

We do not currently have an implementation of calling conventions for any other platform.

Fixes: #7934

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We do not currently have an implementation of calling conventions for
any other platform.

Fixes: diffblue#7934
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a531056) 78.75% compared to head (a738f6d) 78.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7958      +/-   ##
===========================================
+ Coverage    78.75%   78.83%   +0.07%     
===========================================
  Files         1701     1701              
  Lines       196224   196224              
===========================================
+ Hits        154540   154694     +154     
+ Misses       41684    41530     -154     

see 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +202 to +204
if(CMAKE_SYSTEM_NAME STREQUAL Linux AND
(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
CMAKE_SYSTEM_PROCESSOR STREQUAL "i386"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition means that memory analyzer will be built on Mac with Intel.
Is this the intended behaviour?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would not fulfil CMAKE_SYSTEM_NAME STREQUAL Linux.

@NlightNFotis NlightNFotis linked an issue Oct 20, 2023 that may be closed by this pull request
@peterschrammel peterschrammel removed their assignment Oct 20, 2023
@esteffin esteffin merged commit 10f277c into diffblue:develop Oct 20, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build CBMC on AL2023 ARM64 CBMC 5.93.0 cannot be built on non-Intel platforms
3 participants