Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: flattening for non-binary bitnor, bitnand, bitxnor #8542

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

kroening
Copy link
Member

This fixes the flattening for bitnor, bitnand, bitxnor for the case that the expression has one operand or more than two operands.

For one operand, the result is now the bit-wise negation.

For three or more operands, the result is now the bit-wise negation of the bitor, bitand, bitxor with the same operands.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This fixes the flattening for bitnor, bitnand, bitxnor for the case that the
expression has one operand or more than two operands.

For one operand, the result is now the bit-wise negation.

For three or more operands, the result is now the bit-wise negation of
the bitor, bitand, bitxor with the same operands.
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (c4aaafd) to head (1d9e73b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/flattening/boolbv_bitwise.cpp 81.25% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8542      +/-   ##
===========================================
- Coverage    78.55%   78.55%   -0.01%     
===========================================
  Files         1729     1729              
  Lines       199714   199722       +8     
  Branches     18312    18312              
===========================================
- Hits        156892   156888       -4     
- Misses       42822    42834      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review December 23, 2024 11:02
@tautschnig tautschnig merged commit fc4f7ca into develop Dec 23, 2024
39 of 41 checks passed
@tautschnig tautschnig deleted the fix-bitwise-flattening branch December 23, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants