Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enum-range check for LHSs #8544

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix enum-range check for LHSs #8544

merged 1 commit into from
Dec 26, 2024

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the goto-check-c-is-assigned branch 2 times, most recently from bb2ec84 to f6b2022 Compare December 24, 2024 19:22
The check_rec recursion now distinguishes values that are assigned to,
enabling a fix of #8543.
@kroening kroening force-pushed the goto-check-c-is-assigned branch from f6b2022 to 53454fd Compare December 25, 2024 08:57
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (b71084c) to head (53454fd).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/ansi-c/goto-conversion/goto_check_c.cpp 82.75% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8544      +/-   ##
===========================================
- Coverage    78.55%   78.38%   -0.18%     
===========================================
  Files         1729     1729              
  Lines       199722   200151     +429     
  Branches     18312    18244      -68     
===========================================
- Hits        156888   156883       -5     
- Misses       42834    43268     +434     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review December 25, 2024 23:54
@kroening kroening merged commit f9a7807 into develop Dec 26, 2024
37 of 41 checks passed
@kroening kroening deleted the goto-check-c-is-assigned branch December 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants