Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat Add css class "m-overlay__inner" #341

Merged

Conversation

FiestaRuless
Copy link
Contributor

@FiestaRuless FiestaRuless commented Dec 30, 2024

PR Checklist

This PR fulfills the following requirements:

  • The commit message follows our guidelines: Contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A changelog entry was added

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Wanneer een modal geopend wordt, heeft dit niet de functionaliteiten dat hem ooit had.
Zoals het verticaal scrollen.
Zichtbaar op https://digipolisantwerp.github.io/antwerp-ui_angular/modules/layout/modal wanneer men het browser heel klein maakt zodat scrolling nodig is.

Deze class is ooit verwijderd geweest uit de section. In mijn ogen was dit een kleine overzicht want dit bracht breaking changes die nooit opgelost zijn. Dit is ook een scss class dat specifiek hiervoor gemaakt is en nog steeds bestaat.

Verwijderd geweest in deze commit:
82c8a51#diff-3bf724efdd4d4f7fd818bbb1c3523f96f047b3dcb1c3c4c0a41cdbbfc63a98f7L8

@TriangleJuice TriangleJuice merged commit d92dc97 into digipolisantwerp:master Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants